From e6f3a4f7a4874a7fd92ece8f49d507b5a91692bf Mon Sep 17 00:00:00 2001 From: Cappy Ishihara Date: Sun, 2 Jun 2024 03:48:29 +0700 Subject: [PATCH] do it the right way --- src/utils.rs | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/src/utils.rs b/src/utils.rs index f298ffa..1e1b4ca 100644 --- a/src/utils.rs +++ b/src/utils.rs @@ -20,23 +20,10 @@ pub fn rand() -> [u8; 50] { pub fn bytes_into_string(code: &[u8]) -> String { // This *might* be the correct way to do it. - // code.iter().map(|byte| format!("{:02x}", byte)).collect::() // ????? Why do you need this? Why not just String::from_utf8()?? + // code.iter().map(|byte| format!("{:02x}", byte)).collect::() // ????? Why do you need this? Why not just hex::encode? // So we need to turn each byte into a string with a 2-digit hexadecimal representation apparently... - let test_res = hex::encode(code); - - let res = code.iter().fold(String::new(), |mut acc, byte| { - acc.push_str(&format!("{:02x}", byte)); - acc - }); // This is the same as the above, but with a fold instead of a map - - - tracing::debug!(?test_res, ?res, "bytes_into_string"); - - // Can we do this with hex::encode instead? - - - res + hex::encode(code) // This is the correct way to do it. // String::from_utf8_lossy(code).to_string() // Tried this, causes corrupted string }