shiroyashik/sculptor
1
0
Fork 0
mirror of https://github.com/shiroyashik/sculptor.git synced 2025-12-06 04:51:13 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

do it the right way

Browse source
This commit is contained in:
Cappy Ishihara 2024-06-02 03:48:29 +07:00
parent 36b4a79a7e
commit e6f3a4f7a4
No known key found for this signature in database
GPG key ID: 50862C285CB76906
1 changed files with 2 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

17
src/utils.rs
View file

@ -20,23 +20,10 @@ pub fn rand() -> [u8; 50] {
pub fn bytes_into_string(code: &[u8]) -> String { pub fn bytes_into_string(code: &[u8]) -> String {
// This *might* be the correct way to do it. // This *might* be the correct way to do it.
// code.iter().map(|byte| format!("{:02x}", byte)).collect::<String>() // ????? Why do you need this? Why not just String::from_utf8()?? // code.iter().map(|byte| format!("{:02x}", byte)).collect::<String>() // ????? Why do you need this? Why not just hex::encode?
// So we need to turn each byte into a string with a 2-digit hexadecimal representation apparently... // So we need to turn each byte into a string with a 2-digit hexadecimal representation apparently...
let test_res = hex::encode(code); hex::encode(code) // This is the correct way to do it.
let res = code.iter().fold(String::new(), |mut acc, byte| {
acc.push_str(&format!("{:02x}", byte));
acc
}); // This is the same as the above, but with a fold instead of a map
tracing::debug!(?test_res, ?res, "bytes_into_string");
// Can we do this with hex::encode instead?
res
// String::from_utf8_lossy(code).to_string() // Tried this, causes corrupted string // String::from_utf8_lossy(code).to_string() // Tried this, causes corrupted string
} }